Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-37875: Add ltd-upload action #26

Merged
merged 1 commit into from
Nov 3, 2023
Merged

DM-37875: Add ltd-upload action #26

merged 1 commit into from
Nov 3, 2023

Conversation

jonathansick
Copy link
Contributor

This action in the build_docs GitHub Action workflow uploads the package documentation to daf-butler-migrate.lsst.io.

@jonathansick
Copy link
Contributor Author

@andy-slac There seems to be extant type checking errors and documentation build errors. I'm fairly confident this upload step should work once rebased on a fix to the documentation build.

Here's the documentation build error: https://github.com/lsst-dm/daf_butler_migrate/actions/runs/6748033508/job/18345499644?pr=26#step:9:43

Warning, treated as error:
/home/runner/work/daf_butler_migrate/daf_butler_migrate/doc/lsst.daf.butler_migrate/command-line.rst:39:Failed to import "migrate" from "lsst.daf.butler_migrate.cli.cmd". The following exception was raised:
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/sphinx_click/ext.py", line 426, in _load_module
    mod = __import__(module_name, globals(), locals(), [attr_name])
  File "/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/lsst/daf/butler_migrate/cli/cmd/__init__.py", line 24, in <module>
    from .commands import migrate
  File "/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/lsst/daf/butler_migrate/cli/cmd/commands.py", line 28, in <module>
    from ... import script
  File "/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/lsst/daf/butler_migrate/script/__init__.py", line 32, in <module>
    from .rewrite_sqlite_registry import rewrite_sqlite_registry
  File "/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/lsst/daf/butler_migrate/script/rewrite_sqlite_registry.py", line 32, in <module>
    from lsst.daf.butler.registries.sql import SqlRegistry
ModuleNotFoundError: No module named 'lsst.daf.butler.registries'
Error: Process completed with exit code 2.

Is is possible that lsst.daf.butler.registries is not available from the dependencies listed in requirements.txt?

@andy-slac
Copy link
Collaborator

Thanks @jonathansick! daf_butler was reorganized just recently, I forgot that this package needs an update too. Should be an easy fix, I'll add a commit to this PR to fix build errors so we can see that upload works.

This action in the build_docs GitHub Action workflow uploads the package
documentation to daf-butler-migrate.lsst.io.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f4f978) 55.90% compared to head (6ed348a) 55.90%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage   55.90%   55.90%           
=======================================
  Files          32       32           
  Lines        1109     1109           
  Branches      254      254           
=======================================
  Hits          620      620           
  Misses        455      455           
  Partials       34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andy-slac
Copy link
Collaborator

@jonathansick, I did my fix on a new branch and rebased this one. It looks like it builds OK, feel free to merge if things look OK on your side.

@jonathansick jonathansick merged commit 83a83a8 into main Nov 3, 2023
8 checks passed
@jonathansick jonathansick deleted the tickets/DM-37875 branch November 3, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants