Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42509: Extend output of show-current command #31

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Conversation

andy-slac
Copy link
Collaborator

show-current --butler now shows (head) tag similarly to show-current,
this makes it easier to identify managers that need schema upgrade.

`show-current --butler` now shows `(head)` tag similarly to `show-current`,
this makes it easier to identify managers that need schema upgrade.
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (a19f4ec) 54.37% compared to head (0aa4284) 54.36%.

Files Patch % Lines
.../lsst/daf/butler_migrate/script/migrate_current.py 0.00% 5 Missing ⚠️
python/lsst/daf/butler_migrate/scripts.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   54.37%   54.36%   -0.01%     
==========================================
  Files          33       33              
  Lines        1144     1146       +2     
  Branches      256      255       -1     
==========================================
+ Hits          622      623       +1     
- Misses        488      489       +1     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -49,7 +47,7 @@ zip-safe = true
license-files = ["COPYRIGHT", "LICENSE"]

[tool.setuptools.package-data]
"lsst.daf.butler_migrate" = []
"lsst.daf.butler_migrate" = ["py.typed", "cli/resources.yaml"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timj, I noticed that cli/resources.yaml is missing from pipe_base/pyproject.toml, I suppose we need it there too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. Right. Hmm. I don't think any of the pip installable variants work with the butler cli plugins since nothing is setting the environment variable and for pip install we need to be using a different technique for finding these plugins using entry points. Regardless, if pipe_base isn't even including the file in the tar ball that pip installs then it will never work and needs to be fixed.

@andy-slac andy-slac merged commit 2ea602a into main Jan 16, 2024
8 of 10 checks passed
@andy-slac andy-slac deleted the tickets/DM-42509 branch January 16, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants