Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-44007: Improve support for sqlite registries #39

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Conversation

andy-slac
Copy link
Collaborator

Expanded test_dimensions_json tests to include all supported universe
versions, added Postgres tests and tests for schema downgrades.
Updated two migration scripts to work with sqlite backend.

Checklist

  • added documentation for a new migration script

Copy link
Contributor

@dhirving dhirving left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for also taking care of the nsec thing and improving the test coverage.

Expanded test_dimensions_json tests to include all supported universe
versions, added Postgres tests and tests for schema downgrades.
Updated two migration scripts to work with sqlite backend.
@andy-slac andy-slac merged commit 7afde34 into main Apr 23, 2024
10 checks passed
@andy-slac andy-slac deleted the tickets/DM-44007 branch April 23, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants