Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-45767: Use public location of CollectionType #43

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Conversation

timj
Copy link
Member

@timj timj commented Aug 13, 2024

Checklist

  • added documentation for a new migration script

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.41%. Comparing base (d15a6b0) to head (ddecfcf).
Report is 5 commits behind head on main.

Files Patch % Lines
...f/butler_migrate/script/rewrite_sqlite_registry.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   58.44%   58.41%   -0.03%     
==========================================
  Files          38       38              
  Lines        1415     1414       -1     
  Branches      298      298              
==========================================
- Hits          827      826       -1     
  Misses        548      548              
  Partials       40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timj timj merged commit 62059b9 into main Aug 15, 2024
10 of 12 checks passed
@timj timj deleted the tickets/DM-45767 branch August 15, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants