-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-46914: Demonstrate facility name mapping #23
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
=======================================
Coverage 82.29% 82.29%
=======================================
Files 18 18
Lines 1079 1079
Branches 174 174
=======================================
Hits 888 888
Misses 166 166
Partials 25 25 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
facility_map: | ||
LATISS: "Rubin:1.2m" | ||
LSSTComCam: "Rubin:Simonyi" | ||
LSSTCam: "Rubin:Simonyi" | ||
# We don't explicitly specify instrument_name - it's auto-generated from the corresponding Butler dimension | ||
obs_collection: LATISS_LIVE # may evolve as experience with this builds up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would we need similar instrument-specific value for obs_collection
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might end up needing a obs_collection to Butler collection mapping here. cc/ @gpdf
8fc9c30
to
3cfe43c
Compare
Depends on lsst/daf_butler#1122