Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GraphQL Auth plugin and configure user groups #9

Merged
merged 10 commits into from
Jul 13, 2023
Merged

Conversation

kylepratuch
Copy link
Contributor

@dananjohnson I'm leaving this as a draft until we're sure the plugin/groups are configured correctly for the client side of things.

@kylepratuch kylepratuch marked this pull request as ready for review June 21, 2023 22:56
@kylepratuch
Copy link
Contributor Author

This branch contains the Craft updates needed to support @dananjohnson's work implementing authentication in the client. If you're familiar with the setup we used on the main site, there's really nothing new here.

I do want to note a few things (some of which we discussed on a call earlier today):

  • If you're testing this with the locally stored db dump, there's a chance the Educator and Student user group ids won't match the project config. The mismatch manifests as user groups being assigned the wrong schema in the GQL auth plugin settings. With a persistent database this shouldn't happen, but if you see it in a dev environment you can ask Kyle or Dana for a dump with the correct ids already stored.
  • The branch introduces some new environment variables for email/Facebook/Google auth. Blake, you may have some opinions about how you want to handle these in the repo, and we're happy to make changes to align with your expectations and preferences here.
  • If you're wondering why the craft/generator dev dependency is needed for auth.... it's not, and should have been on a different branch. We'll need it soon though, so if you can forgive me for including it in this PR I would appreciate it. 🥲

@kylepratuch kylepratuch requested a review from blnkt June 29, 2023 23:07
@kylepratuch kylepratuch merged commit 059d10a into develop Jul 13, 2023
@kylepratuch kylepratuch deleted the kp/gql-auth branch July 13, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants