Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(profile::core::fiberspec) add spectrometer udev rule #1134

Merged
merged 4 commits into from
Apr 29, 2024
Merged

(profile::core::fiberspec) add spectrometer udev rule #1134

merged 4 commits into from
Apr 29, 2024

Conversation

dtapiacl
Copy link
Contributor

@dtapiacl dtapiacl added the enhancement New feature or request label Apr 25, 2024
@dtapiacl dtapiacl self-assigned this Apr 25, 2024
@dtapiacl dtapiacl changed the title (profile::core::avantes) add spectrometer udev rule (WIP) add spectrometer udev rule Apr 25, 2024
@dtapiacl dtapiacl force-pushed the IT-5290_udev_rule_spectrograph branch 6 times, most recently from 57331ba to 6f7d451 Compare April 26, 2024 15:51
@dtapiacl dtapiacl changed the title (WIP) add spectrometer udev rule (profile::core::fiberspec) add spectrometer udev rule Apr 26, 2024
@dtapiacl dtapiacl force-pushed the IT-5290_udev_rule_spectrograph branch from 6f7d451 to c5165fd Compare April 26, 2024 17:19
jhoblitt
jhoblitt approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dtapiacl dtapiacl merged commit 7ecdc84 into production Apr 29, 2024
10 checks passed
@dtapiacl dtapiacl deleted the IT-5290_udev_rule_spectrograph branch April 29, 2024 14:01
@jhoblitt jhoblitt mentioned this pull request May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhoblitt jhoblitt jhoblitt approved these changes

@cbarria cbarria Awaiting requested review from cbarria

@csilva-cl csilva-cl Awaiting requested review from csilva-cl

Assignees

@dtapiacl dtapiacl

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtapiacl @jhoblitt