Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(role/amor.yaml) update network config #1139

Merged
merged 2 commits into from
May 7, 2024
Merged

(role/amor.yaml) update network config #1139

merged 2 commits into from
May 7, 2024

Conversation

dtapiacl
Copy link
Contributor

@dtapiacl dtapiacl commented May 6, 2024

No description provided.

@dtapiacl dtapiacl added the enhancement New feature or request label May 6, 2024
@dtapiacl dtapiacl requested review from jhoblitt, cbarria and csilva-cl May 6, 2024 23:29
@dtapiacl dtapiacl self-assigned this May 6, 2024
jhoblitt
jhoblitt requested changes May 6, 2024
View reviewed changes
Copy link
Member

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most changes should have spec coverage.

@dtapiacl dtapiacl requested a review from jhoblitt May 7, 2024 00:12
jhoblitt
jhoblitt requested changes May 7, 2024
View reviewed changes
Copy link
Member

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hostname should be change to match the real host to avoid confusion in the future. Otherwise, looks good.

spec/hosts/nodes/love1.cp.lsst.org_spec.rb Outdated Show resolved Hide resolved
@dtapiacl dtapiacl force-pushed the IT-5312_update_love_cp branch from cbf87df to f6e0962 Compare May 7, 2024 00:41
@dtapiacl dtapiacl force-pushed the IT-5312_update_love_cp branch from f6e0962 to 2be5882 Compare May 7, 2024 00:43
@dtapiacl dtapiacl requested a review from jhoblitt May 7, 2024 00:44
@dtapiacl dtapiacl merged commit 5da7fa6 into production May 7, 2024
10 checks passed
@dtapiacl dtapiacl deleted the IT-5312_update_love_cp branch May 7, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhoblitt jhoblitt jhoblitt approved these changes

@cbarria cbarria Awaiting requested review from cbarria

@csilva-cl csilva-cl Awaiting requested review from csilva-cl

Assignees

@dtapiacl dtapiacl

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtapiacl @jhoblitt