Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(node/lsstcam-quad.cp.lsst.org) deploy host as el9 #1149

Merged
merged 2 commits into from
Jun 11, 2024
Merged

(node/lsstcam-quad.cp.lsst.org) deploy host as el9 #1149

merged 2 commits into from
Jun 11, 2024

Conversation

dtapiacl
Copy link
Contributor

No description provided.

@dtapiacl dtapiacl added the enhancement New feature or request label May 14, 2024
@dtapiacl dtapiacl self-assigned this May 14, 2024
@dtapiacl dtapiacl force-pushed the IT-5343_lsstcam_quad branch 2 times, most recently from 72b3246 to 7e182f4 Compare May 14, 2024 16:14
@dtapiacl dtapiacl force-pushed the IT-5343_lsstcam_quad branch from 7e182f4 to dfd0d55 Compare May 14, 2024 17:49
@dtapiacl dtapiacl force-pushed the IT-5343_lsstcam_quad branch 3 times, most recently from 8371a23 to 3b86858 Compare May 15, 2024 23:45
@dtapiacl dtapiacl requested a review from jhoblitt May 15, 2024 23:46
jhoblitt
jhoblitt approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The device and both static IPs have been confirmed as being present in ipam.

@dtapiacl dtapiacl requested a review from jhoblitt May 23, 2024 15:25
jhoblitt
jhoblitt approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you updating ipam.

jhoblitt
jhoblitt requested changes May 30, 2024
View reviewed changes
Copy link
Member

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash 3b86858

@dtapiacl dtapiacl force-pushed the IT-5343_lsstcam_quad branch from 7506372 to ef053a4 Compare May 30, 2024 01:26
@dtapiacl
Copy link
Contributor Author

Please squash 3b86858

Commit was squashed on to: cf05f59

@dtapiacl dtapiacl force-pushed the IT-5343_lsstcam_quad branch from ef053a4 to 25d9de0 Compare May 30, 2024 01:27
@dtapiacl dtapiacl requested a review from jhoblitt May 30, 2024 01:28
@csilva-cl
Copy link
Contributor

Please squash 3b86858

why squashing? perhaps a more descriptive commit message is better?

@dtapiacl dtapiacl force-pushed the IT-5343_lsstcam_quad branch from 25d9de0 to 963ede0 Compare June 10, 2024 23:46
@dtapiacl dtapiacl force-pushed the IT-5343_lsstcam_quad branch from 963ede0 to 6b733bb Compare June 11, 2024 19:08
@dtapiacl dtapiacl merged commit b87e4d4 into production Jun 11, 2024
10 checks passed
@dtapiacl dtapiacl deleted the IT-5343_lsstcam_quad branch June 11, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmorris glennmorris glennmorris approved these changes

@jhoblitt jhoblitt jhoblitt approved these changes

@cbarria cbarria Awaiting requested review from cbarria

@csilva-cl csilva-cl Awaiting requested review from csilva-cl

Assignees

@dtapiacl dtapiacl

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dtapiacl @csilva-cl @jhoblitt @glennmorris