Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(role/tang) fwv #942

Merged
merged 16 commits into from
Nov 16, 2023
Merged

(role/tang) fwv #942

merged 16 commits into from
Nov 16, 2023

Conversation

jhoblitt
Copy link
Member

@jhoblitt jhoblitt commented Oct 4, 2023 •
edited
Loading

@jhoblitt jhoblitt added the enhancement New feature or request label Oct 4, 2023
@jhoblitt jhoblitt force-pushed the IT-4777/tang.dev branch 17 times, most recently from 8cef676 to bac5fa7 Compare November 11, 2023 00:26
@jhoblitt jhoblitt changed the title (WIP) (role/tang) fwv (role/tang) fwv Nov 11, 2023
cbarria
cbarria approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@cbarria cbarria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great 👍🏻

@jhoblitt jhoblitt force-pushed the IT-4777/tang.dev branch 5 times, most recently from 9771386 to 7fc97b4 Compare November 15, 2023 15:09
@jhoblitt jhoblitt requested a review from bastelfreak November 15, 2023 19:07
tuxmea
tuxmea approved these changes Nov 16, 2023
View reviewed changes
Copy link

@tuxmea tuxmea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhoblitt jhoblitt merged commit 6fee88c into production Nov 16, 2023
12 checks passed
@jhoblitt jhoblitt deleted the IT-4777/tang.dev branch November 16, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbarria cbarria cbarria approved these changes

@tuxmea tuxmea tuxmea approved these changes

@csilva-cl csilva-cl Awaiting requested review from csilva-cl

@dtapiacl dtapiacl Awaiting requested review from dtapiacl

@bastelfreak bastelfreak Awaiting requested review from bastelfreak

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jhoblitt @bastelfreak @tuxmea @cbarria