Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(node/foreman.*) migrate dhcp pool configuration from site/role -> node layer(s) #964

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

jhoblitt
Copy link
Member

@jhoblitt jhoblitt commented Nov 1, 2023

This is to facilitate spinning up test VMs with the foreman role that do not become a rogue dhcp server.

@jhoblitt jhoblitt added the enhancement New feature or request label Nov 1, 2023
@jhoblitt jhoblitt changed the title (node/foreman*) migrate dhcp pool configuration from site/role -> node layer(s) (node/foreman.*) migrate dhcp pool configuration from site/role -> node layer(s) Nov 1, 2023
Copy link
Contributor

@dtapiacl dtapiacl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jhoblitt jhoblitt merged commit 17661f3 into production Nov 3, 2023
13 checks passed
@jhoblitt jhoblitt deleted the IT-4854/dhcp-pools branch November 3, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants