Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(profile::pi::ftdi) fwv #996

Merged
merged 2 commits into from
Nov 20, 2023
Merged

(profile::pi::ftdi) fwv #996

merged 2 commits into from
Nov 20, 2023

Conversation

jhoblitt
Copy link
Member

No description provided.

@jhoblitt jhoblitt added the enhancement New feature or request label Nov 17, 2023
@jhoblitt jhoblitt marked this pull request as draft November 17, 2023 22:49
@jhoblitt jhoblitt marked this pull request as ready for review November 17, 2023 23:19
fritzm
fritzm approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@fritzm fritzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhoblitt jhoblitt merged commit 4415c42 into production Nov 20, 2023
14 checks passed
@jhoblitt jhoblitt deleted the IT-4860/ttyusb branch November 20, 2023 16:57
wvreeven
wvreeven reviewed Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@wvreeven wvreeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the rule locally with a serial-to-USB converter cable as used at the summit and the group permission was set as expected. Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wvreeven wvreeven wvreeven left review comments

@fritzm fritzm fritzm approved these changes

@cbarria cbarria Awaiting requested review from cbarria

@bstalder bstalder Awaiting requested review from bstalder

@csilva-cl csilva-cl Awaiting requested review from csilva-cl

@dtapiacl dtapiacl Awaiting requested review from dtapiacl

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhoblitt @fritzm @wvreeven