Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-46777: sphinx < 8.1.0 #231

Merged
merged 2 commits into from
Oct 10, 2024
Merged

DM-46777: sphinx < 8.1.0 #231

merged 2 commits into from
Oct 10, 2024

Commits on Oct 10, 2024

  1. DM-46777: sphinx < 8.1.0 

    [Sphinx
8.1.0](sphinx-doc/sphinx@v8.0.2...v8.1.0)
contains [a
commit](https://github.com/sphinx-doc/sphinx/pull/12762/files#diff-a4c6bf1492ef480b94af82c988f64ca56fa256fab0ed043a5ad3d4043f89a645L14)
that removes the `ExtensionError` export from the `sphinx.util` package.
This currently breaks the
[sphinxcontrib-mermaid](https://github.com/mgaitan/sphinxcontrib-mermaid)
dependency:

```
File
"/home/danfuchs/src/safir/.nox/docs-clean/lib/python3.12/site-packages/sphinxcontrib/autoclassdiag.py",
line 3, in <module>    from sphinx.util import ExtensionError,
import_objectImportError: cannot import name 'ExtensionError' from
'sphinx.util'
(/home/danfuchs/src/safir/.nox/docs-clean/lib/python3.12/site-packages/sphinx/util/__init__.py)
```

Pin to < 8.1.0 for now until this gets fixed in either sphinx or
sphinxcontrib-mermaid (and any other packages that we use that might
also be broken)
    @fajpunk
    fajpunk committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    1dac3ed View commit details
    Browse the repository at this point in the history

  2. Ignore type error from newer mypy on file that will be removed in fut… 

    …ure versions
    @fajpunk
    fajpunk committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    6e23b31 View commit details
    Browse the repository at this point in the history