Cleanup dependecies & upgrade log4j #106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tests
Test were done by building tap service image locally, and deploying on data-dev by pointing the image of the cadc-tap deployment to this locally created one.
The following tests were run:
Taplint:
Expected: Totals: Errors: 97; Warnings: 695; Infos: 158; Summaries: 20; Failures: 3 (on main version)
Actual: Totals: Errors: 97; Warnings: 695; Infos: 158; Summaries: 20; Failures: 3 (tickets/DM-45142)
Errors & warning match between the two (This should eventually be an automated test)
Notebooks:
DP02_02_Catalog_Queries_with_TAP (Sucess)
DC2_catalog_access (Sucess)
DP02_13a_Image_Cutout_SciDemo (Sucess)
Firefly:
Test DP02 tab with object: 62, -37 (Success)
Test D02 with query: SELECT TOP 10 * FROM dp02_dc2_catalogs.Object (Success)
TAP_UPLOAD Not tested (Not possible atm)