Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup dependecies & upgrade log4j #106

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Cleanup dependecies & upgrade log4j #106

merged 3 commits into from
Jul 15, 2024

Conversation

stvoutsin
Copy link
Member

Summary

  • Removes duplicate cadc libraries (adql)
  • Remove cadc libraries (adql) that are not needed
  • Remove dali lib that was causing an issue with TAP_UPLOAD with binary data, due to conflict with stilts lib
  • Upgrade libraries cadc-util, cadc-vosi
  • Upgrade log4j (To address vulnerability issue)

Tests

Test were done by building tap service image locally, and deploying on data-dev by pointing the image of the cadc-tap deployment to this locally created one.

The following tests were run:

Taplint:

Expected: Totals: Errors: 97; Warnings: 695; Infos: 158; Summaries: 20; Failures: 3 (on main version)
Actual: Totals: Errors: 97; Warnings: 695; Infos: 158; Summaries: 20; Failures: 3 (tickets/DM-45142)

Errors & warning match between the two (This should eventually be an automated test)

Notebooks:
DP02_02_Catalog_Queries_with_TAP (Sucess)
DC2_catalog_access (Sucess)
DP02_13a_Image_Cutout_SciDemo (Sucess)

Firefly:
Test DP02 tab with object: 62, -37 (Success)
Test D02 with query: SELECT TOP 10 * FROM dp02_dc2_catalogs.Object (Success)
TAP_UPLOAD Not tested (Not possible atm)

@stvoutsin stvoutsin merged commit 6e7f455 into master Jul 15, 2024
2 checks passed
@stvoutsin stvoutsin deleted the tickets/DM-45142 branch July 15, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant