[DM-37254] Emit exception message as warning #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now this is printed out at the debug level, but it will be a lot easier to find and get a hold of if we make it a warning. Since this is an exception path, this shouldn't really add too much log spam, considering the rethrown messages are emitted after, but we seem to lose the first one which is the most important.
cbanek
force-pushed
the
tickets/DM-37254
branch
from
10ab755
to
5c1a139
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now this is printed out at the debug level, but it will be a lot easier to find and get a hold of if we make it a warning. Since this is an exception path, this shouldn't really add too much log spam, considering the rethrown messages are emitted after, but we seem to lose the first one which is the most important.