DM-37934: Remove advertisements for ADQL geometry entities not supported by Qserv #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktlim
approved these changes
May 6, 2023
cbanek
force-pushed
the
tickets/DM-37934-2
branch
from
b37612b
to
c6413cf
Compare
cbanek
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following consultation with @ktlim and @iagaponenko (who might not be able to see this repo?) I'm removing statements from the Qserv-based TAP service's
/capabilitiesresponse for ADQL constructs that are not currently supported in Qserv:REGION,INTERSECTS,AREA,CENTROID,COORD1, andCOORD2.Compared to the recent fix re:
UPLOAD, this is less urgent, because Firefly does not (yet) condition its behavior on these features.