[DM-41951] setAutoCommit to false #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbanek
force-pushed
the
tickets/DM-41951
branch
from
ee98fd8
to
4cd8d9e
Compare
This seems to be holding a lot of memory up on the server by holding open a transaction, but we don't need a transaction just for SELECTs.
cbanek
force-pushed
the
tickets/DM-41951
branch
from
4cd8d9e
to
4b78a50
Compare
cbanek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting auto commit to false, it should reduce the memory usage and seems to be one of the parts of making sure we use a cursor for the select statements. If we don't use a cursor then the jdbc driver reads everything into memory before returning it.