Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#dm-docs-support -> #square-docs-support #69

Merged
merged 3 commits into from
Nov 19, 2024
Merged

#dm-docs-support -> #square-docs-support #69

merged 3 commits into from
Nov 19, 2024

Conversation

fajpunk
Copy link
Member

@fajpunk fajpunk commented Nov 15, 2024

Also, this build had rotted a bit, so I did some stuff to fix it:

  • The types-pkg_resources package has been yanked from pypi. I replaced it with the types-setuptools package.
  • The GitHub CI job needs AWS creds, it was using creds attached to Jonathan’s human IAM user. I made a new IAM user with access only to the lsst-the-docs-test S3 bucket.
  • Changed the LTD_TEST_AWS_ID and LTD_TEST_BUCKET GitHub repo secrets into variables so that repo admins can see their values (LTD_TEST_AWS_SECRET remains a secret).
  • Generated an access key for the new user and put the creds in the GitHub vars/secrets.
  • Documented the GitHub CI / AWS integration.

@fajpunk fajpunk requested review from rra and jonathansick November 15, 2024 00:32
@fajpunk fajpunk force-pushed the tickets/DM-47580 branch 6 times, most recently from 7bb8c0b to 905f5f9 Compare November 19, 2024 16:07
[types-pkg_resources](https://pypi.org/project/types-pkg-resources/) has
been yanked from pypi, replaced by
[types-setuptools](https://pypi.org/project/types-setuptools/)
@fajpunk fajpunk requested a review from rra November 19, 2024 16:13
@fajpunk fajpunk enabled auto-merge November 19, 2024 16:30
@fajpunk fajpunk merged commit a4e30b9 into main Nov 19, 2024
8 checks passed
@fajpunk fajpunk deleted the tickets/DM-47580 branch November 19, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants