Skip to content

Commit

Permalink
Update commentary in test.
Browse files Browse the repository at this point in the history
  • Loading branch information
athornton committed Aug 1, 2024
1 parent e29b4df commit c08bcd2
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions tests/support/jupyter.py
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,12 @@ def lab_callback(self, request: Request) -> Response:
to a callback, and then back to the lab), but it's hopefully good
enough to test handling of cookies during redirect chains for
capturing the ``_xsrf`` cookie.
Well...it's not realistic enough, in that the test cases passed but
in practice the ``_xsrf`` cookie would expire. I think that that is
fixed now (similar strategy of following redirects manually and
grabbing the cookie at each intermediate step), but I don't
understand how to test it.
"""
user = self.get_user(request.headers["Authorization"])
assert str(request.url).endswith(f"/user/{user}/callback")
Expand Down

0 comments on commit c08bcd2

Please sign in to comment.