Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-47811: Fixes to address FAST001 and FAST002 ruff rules and update-deps #232 #385

Merged
merged 1 commit into from
Nov 27, 2024
Merged

DM-47811: Fixes to address FAST001 and FAST002 ruff rules and update-deps #232 #385

merged 1 commit into from
Nov 27, 2024

Conversation

stvoutsin
Copy link
Member

Fix ruff rules FAST001 & FAST002 which were introduced in ruff version 0.8.0

This PR addresses this in the following way:

  • Updates the dependencies including ruff
  • Removes the response_model param which is no longer needed
  • A few changes to the order of imports which are autofixes

rra
rra approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@rra rra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good minus the change log. Thanks!

changelog.d/20241126_224636_steliosvoutsinas.md Outdated Show resolved Hide resolved
@stvoutsin stvoutsin merged commit 1e726ab into main Nov 27, 2024
4 checks passed
@stvoutsin stvoutsin deleted the tickets/DM-47811 branch November 27, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rra rra rra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stvoutsin @rra