Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Redis queue to sasquatch-backpack's usgs module #52

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

Fireye04
Copy link
Member

No description provided.

@Fireye04
Copy link
Member Author

Fireye04 commented Nov 21, 2024

Adding the queue brings up some interesting questions as to what to do with the locally run command. In an ideal world, the local instance is able to query the remote redis database and determine what to send and what not to send. However until that's figured out, running locally runs into a problem where sending data to remote will end up duplicating items. For now I'm going to rename the --dry-run flag default to --post and default it to False, to indicate that that posting is an explicit decision that should be made rather than the default behavior locally, as we want to minimize these duplicates as much as possible while we get that remote query working.

@Fireye04
Copy link
Member Author

Very broken right now; to be fixed as soon as possible. Old implementation was too specific in scope and needed a minor refacor away from pydantic redis towards some kind of set storage solution via redis? Intended usage is to actually use the keys and values rather than just check the keys for the presence of an id, and place garbage in the values, which feels stupid.

@Fireye04
Copy link
Member Author

Fireye04 commented Dec 4, 2024

To add tests.

@Fireye04
Copy link
Member Author

tests still unable to locate the tox-hosted redis server. Will continue to debug on thursday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant