Skip to content

Commit

Permalink
Tidy up as per PR recommendations
Browse files Browse the repository at this point in the history
  • Loading branch information
ugyballoons committed Sep 3, 2024
1 parent cf2cb0e commit 5aaf5ec
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions tests/handlers/external_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ async def test_all_endpoints(
all_cams = [f"{summit.name}/{cam.name}" for cam in summit.cameras]
online_cams = [f"{summit.name}/{cam.name}" for cam in summit.cameras if cam.online]
camera_historical = [f"{cam}/historical" for cam in online_cams]
camera_dates = [f"{cam}/date/{day_obs}" for cam in online_cams if cam]
camera_dates = [f"{cam}/date/{day_obs}" for cam in online_cams]
nr_current = [f"{cam}/night_report" for cam in online_cams]
nr_dates = [f"{cam}/night_report/{day_obs}" for cam in online_cams]

Expand Down Expand Up @@ -175,9 +175,6 @@ async def test_request_invalid_dates(
res = await client.get(url)
assert res.is_error

# TODO: This needs not to be just a success, but a page with a
# 'nothing for this day' message.
# See DM-45327 https://rubinobs.atlassian.net/browse/DM-45327
for url_frag in cam_empty_year:
url = f"/{app_name}/{url_frag}"
res = await client.get(url)
Expand Down

0 comments on commit 5aaf5ec

Please sign in to comment.