DM-40149: Rewrite RubinTV with FastAPI #154
Conversation
mfisherlevine
force-pushed
the
tickets/DM-40149
branch
from
d4100a2
to
9d390b1
Compare
ugyballoons
force-pushed
the
tickets/DM-40149
branch
6 times, most recently
from
4bd0045
to
c367dad
Compare
ugyballoons
force-pushed
the
tickets/DM-40149
branch
2 times, most recently
from
ce32c21
to
b138e7d
Compare
ugyballoons
force-pushed
the
tickets/DM-40149
branch
2 times, most recently
from
b650652
to
5dda55c
Compare
ugyballoons
force-pushed
the
tickets/DM-40149
branch
3 times, most recently
from
a16b133
to
597cf75
Compare
.flake8
Outdated
There was a problem hiding this comment.
When moving to the T&S repositories, we there use a tool called ts_pre_commit, which standardizes code quality rules configurations across developers. I'll leave this here for future reference: https://tssw-developer.lsst.io/development-guidelines/tools/pre_commit.html#ts-pre-commit-conf. Then we won't need to have this kind of configuration files.
There was a problem hiding this comment.
OK, thanks Sebastian, I'll give that a proper read and then implement it.
.github/workflows/ci.yaml
Outdated
There was a problem hiding this comment.
On the T&S repositories we also use a Jenkins pipelines for handling docker builds and pushes. I'll try looking how to migrate this part too. For some details check: https://tssw-developer.lsst.io/development-guidelines/building.html.
There was a problem hiding this comment.
I'll read that tomorrow too. Thanks again :)
ugyballoons
force-pushed
the
tickets/DM-40149
branch
from
8b351ce
to
0d12980
Compare
There was a problem hiding this comment.
I've left several comments mainly related to aesthetic code stuff, I hope you can look. Besides that this looks like a great job, so it good to me 👍. Thanks @mfisherlevine and @ugyballoons!
| filename: str, | ||
| request: Request, | ||
| ) -> StreamingResponse: | ||
| # auxtel_night_report_2023-08-16_Coverage_airmass |
There was a problem hiding this comment.
What is this line for?
sebastian-aranda
force-pushed
the
tickets/DM-40149
branch
5 times, most recently
from
517af71
to
4ebb372
Compare
sebastian-aranda
force-pushed
the
tickets/DM-40149
branch
from
a9441ab
to
1bf0fb5
Compare
sebastian-aranda
force-pushed
the
tickets/DM-40149
branch
from
d41d888
to
4b4390f
Compare
Historical data now loads all metadata into memory It also stores more efficiently for retreival TableView seq nums are sorted as numbers
Fix bug currentpoller where nothing was passing through the metadata filter.
Also added TMA channel 'M1M3 HP and Slew Profile'
Start making suggested changes from DM-40149: Rewrite RubinTV with FastAPI #154
ugyballoons
force-pushed
the
tickets/DM-40149
branch
from
3b24e37
to
4d7fe83
Compare
ugyballoons
force-pushed
the
tickets/DM-40149
branch
from
4d7fe83
to
e63897c
Compare
sebastian-aranda
force-pushed
the
tickets/DM-40149
branch
from
e63897c
to
4b4390f
Compare
ugyballoons
force-pushed
the
tickets/DM-40149
branch
from
4b4390f
to
e213db1
Compare
No description provided.