Connect environment variables for the ddv flutter build script #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-aranda
changed the title
ugyballoons
reviewed
Jul 10, 2024
scripts/build-flutter-app.sh
Outdated
| @@ -5,15 +5,13 @@ set -e | |||
| # Display each command as it's run. | |||
| set -x | |||
|
|
|||
| DEPLOY_BRANCH=deploy-slac | |||
|
|
|||
| cd /usr/src/rubintv | |||
| git clone --single-branch --branch $DEPLOY_BRANCH https://github.com/lsst-sitcom/rubin_chart | |||
| git clone --single-branch --branch $DEPLOY_BRANCH https://github.com/lsst-ts/rubintv_visualization ./ddv | |||
There was a problem hiding this comment.
If this is going to be set by environment var, would it be useful to have a more specified name, i.e. DDV_DEPLOY_BRANCH?
There was a problem hiding this comment.
good idea! that would be better. I'll make the change 👍.
ugyballoons
reviewed
Jul 10, 2024
scripts/build-flutter-app.sh
Outdated
| cd /usr/src/rubintv | ||
| git clone --single-branch --branch $DEPLOY_BRANCH https://github.com/lsst-sitcom/rubin_chart | ||
| git clone --single-branch --branch $DEPLOY_BRANCH https://github.com/lsst-ts/rubintv_visualization ./ddv | ||
|
|
||
| # Base HREF must be bookended by "/". | ||
| DDV_BASE_HREF=/rubintv/ddv/ | ||
| CLIENT_WS_ADDRESS=rubintv/ws/ddv | ||
| CLIENT_WS_ADDRESS=${CLIENT_WS_ADDRESS:-rubintv/ws/ddv} |
There was a problem hiding this comment.
And I guess the same here?
sebastian-aranda
force-pushed
the
tickets/DM-44839
branch
from
f30c462
to
82dff68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjuts the
scripts/build-flutter-app.shin order to connect environment variables set on the different deployments.