Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SITCOM-1834: Trim returned schema by removing the empty columns #11

Merged
merged 8 commits into from
Feb 10, 2025
Merged

SITCOM-1834: Trim returned schema by removing the empty columns #11

merged 8 commits into from
Feb 10, 2025

Conversation

ugyballoons
Copy link
Contributor

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

fred3m
fred3m reviewed Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@fred3m fred3m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I would implement all of the method directly in the ConsDbSchema class. This should also have some tests added to verify that it's working properly.

@ugyballoons ugyballoons merged commit 4d95379 into main Feb 10, 2025
5 checks passed
@ugyballoons ugyballoons deleted the tickets/SITCOM-1834 branch February 10, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fred3m fred3m fred3m left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ugyballoons @fred3m