SITCOM-1761: Adding butler 'get fits image' and test/config updates #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fred3m
reviewed
Nov 27, 2024
There was a problem hiding this comment.
This looks good. Please fix the linting errors and make sure all of the github actions pass, then this is ok to merge. Note: don't worry about the yaml errors, the project changed the github actions and added the warnings for those and I'll take care of them in another ticket.
|
There is one residual linting complaint that was there before my commits and doesn't seem to fail the checks: |
kadrlica
force-pushed
the
tickets/SITCOM-1761
branch
from
f7ce421 to
3f9902d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes