BLOCK-T523: scripts for monochromatic flats #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elanaku
requested changes
Aug 15, 2025
There was a problem hiding this comment.
My concern with running stopPropagateLaser at the beginning of this block is that the script will fail if the laser is not propagating.
parfa30
force-pushed
the
tickets/BLOCK-T523
branch
3 times, most recently
from
169dd45 to
9063aaa
Compare
|
I've put in power_on_tunablelaser and power_off_tunablelaser instead of the direct commands. The last I checked, those scripts weren't working as well as I wished, but that would be a different ticket. Atleast those scripts are set up to check the state of the laser and only turn it on/off if it was in the other state. |
parfa30
force-pushed
the
tickets/BLOCK-T523
branch
2 times, most recently
from
28b810f to
046a1da
Compare
parfa30
force-pushed
the
tickets/BLOCK-T523
branch
from
046a1da to
9d1752e
Compare
parfa30
force-pushed
the
tickets/BLOCK-T523
branch
from
9d1752e to
4e441e1
Compare
tribeiro
requested changes
Sep 30, 2025
parfa30
force-pushed
the
tickets/BLOCK-T523
branch
from
4e441e1 to
1c9b660
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.