Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update smoke-test.yml #102

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Update smoke-test.yml #102

merged 1 commit into from
Apr 11, 2024

Conversation

astronomerritt
Copy link
Collaborator

@astronomerritt astronomerritt commented Apr 11, 2024

Fixes #101.

I already did this for the unit tests but didn't fix the smoke tests. Essentially we need to make sure that the workflow runs pip install -e .[dev] with the -e so that the repo's directory structure is maintained. If we don't include the -e then the unit tests can't find the testing database.

I don't know why installing without the editable environment flag changes the directory structure from that of the repo and I haven't been able to find out why. Yet.

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does adler run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

Fixes #101.

I already did this for the unit tests but didn't fix the smoke tests. Essentially we need to make sure that the workflow runs pip install -e .[dev] with the -e so that the repo's directory structure is maintained. If we don't include the -e then the unit tests can't find the testing database.
@astronomerritt astronomerritt requested a review from mschwamb April 11, 2024 10:47
@astronomerritt astronomerritt marked this pull request as ready for review April 11, 2024 15:12
@astronomerritt astronomerritt merged commit 48ea809 into main Apr 11, 2024
6 checks passed
@mschwamb mschwamb deleted the astronomerritt-patch-1 branch April 11, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

daily smoke tests failing on finding the sqlite file
2 participants