Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming dataclasses folder, fixing linting. #176

Merged
merged 5 commits into from
Oct 8, 2024

Conversation

astronomerritt
Copy link
Collaborator

@astronomerritt astronomerritt commented Oct 8, 2024

I did an incredibly silly thing when I named one of the Adler folders "dataclasses" - that's the name of an inbuilt Python library. (Which I am actually USING so you think I'd know.) We've gotten away with it up until today - but now I'm getting circular import errors on adler-day.

I've renamed the "dataclasses" folder to "objectdata" and carried the change through to everywhere in the code and in the notebooks.

I also fixed linting, yay!

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does adler run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

@astronomerritt astronomerritt requested a review from jrob93 October 8, 2024 11:54
@astronomerritt astronomerritt changed the title Renaming dataclasses folder. Renaming dataclasses folder, fixing linting. Oct 8, 2024
@astronomerritt astronomerritt marked this pull request as ready for review October 8, 2024 12:09
Copy link
Collaborator

@jrob93 jrob93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've fixed the notebook in docs and checks look to be passing now.

@astronomerritt astronomerritt merged commit ae83173 into main Oct 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants