Renaming dataclasses folder, fixing linting. #176
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did an incredibly silly thing when I named one of the Adler folders "dataclasses" - that's the name of an inbuilt Python library. (Which I am actually USING so you think I'd know.) We've gotten away with it up until today - but now I'm getting circular import errors on adler-day.
I've renamed the "dataclasses" folder to "objectdata" and carried the change through to everywhere in the code and in the notebooks.
I also fixed linting, yay!
Review Checklist for Source Code Changes