Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding adler-day draft script #180

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Adding adler-day draft script #180

merged 4 commits into from
Nov 5, 2024

Conversation

astronomerritt
Copy link
Collaborator

Fixes #175.

  • Adds a draft script for adler-day. All it does right now is calculate and save new phase parameters for ten random objects about half-way through the survey - but it's something to build on.
  • Added a test database I'm using with adler-day for now.
  • Renamed adler.py because as Jamie pointed out, it causes confusion with the package name.

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does adler run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

@astronomerritt astronomerritt requested a review from jrob93 October 22, 2024 12:11
@astronomerritt astronomerritt marked this pull request as ready for review October 22, 2024 12:11
Copy link
Collaborator

@jrob93 jrob93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey this looks great. I take it that this is simply invoked as python adler_day.py when on the adler-day node? I haven't tested it directly on this node but it looks to be doing all the right things so if it runs for you I'm happy. Only comment is could we move adler-day-testing.db out of the top dir and to a testing folder, e.g. tests/data? Just for neatness

@jrob93
Copy link
Collaborator

jrob93 commented Oct 22, 2024

Thanks also for updating adler.py -> adler_run.py. I've just pushed a commit that should mean that calling adler on the command line runs adler_run.py. If that looks good to you go ahead and merge.

(my new trimmed down functionality for adler_run.py will be implemented in PR #178 )

@astronomerritt
Copy link
Collaborator Author

Good catch on the pyproject.toml file. I'll move the database in a second!

@astronomerritt astronomerritt merged commit 7da879f into main Nov 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic adler-day script
2 participants