New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data classes #56

Merged

astronomerritt merged 2 commits into main from data_classes

Mar 5, 2024

Collaborator

astronomerritt commented Mar 1, 2024

Fixes #54.

All DataSchema child classes are now Python dataclasses, with their attributes initialised with empty defaults.
Docstrings have been updated explaining each attribute. I pulled the descriptions directly from https://dm.lsst.org/sdm_schemas/browser/dp03.html.

Fixes #55.

I am no longer storing the SQL query and the AstroPy data table on the DataSchema objects. Because that would be silly.

Additional changes:

I made a tiny change so that mjd is instead being stored as midpointMjdTai to bring it in line with the DiaSource table column heading.
Corrected some docstrings.

Review Checklist for Source Code Changes

Does pip install still work?
Have you written a unit test for any new functions?
Do all the units tests run successfully?
Does adler run successfully on a test set of input files/databases?
Have you used black on the files you have updated to confirm python programming style guide enforcement?

astronomerritt added 2 commits

March 1, 2024 12:47


          Implementing Python dataclasses.

81e79a1


          Putting missing imports back.

astronomerritt requested a review from jrob93

March 1, 2024 12:59

jrob93 approved these changes

View reviewed changes

astronomerritt merged commit 1b9e784 into main

6 checks passed

astronomerritt deleted the data_classes branch

March 5, 2024 11:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet