-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit of AdlerData class. #65
Conversation
Updated to make recommended changes. |
...and forgot to push. Done now. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
=========================================
+ Coverage 0 72.46% +72.46%
=========================================
Files 0 3 +3
Lines 0 69 +69
=========================================
+ Hits 0 50 +50
- Misses 0 19 +19 ☔ View full report in Codecov by Sentry. |
instead of phase_parameter1 and phase_parameter2 what about phase_parameters= [[parameter1,parameter2], [parameter1],] if we happen to be running multiple models. |
I was trying to avoid too many nested lists - this would mean that phase_parameter is nested three times, for filter, model and then parameter. I will still do this if you think it's best, but I worry about maintainability when someone who isn't me has to read the code. |
phase_parameter_err is a variable twice |
Fair enough,but is nested better than having nulls or empty arrays when you don't have a parameter2 for 1 model? |
Mistake in the docstring only, they're separate in the function. Correcting. |
Point taken. I can make this change, one second. |
Done. In retrospect, now I've made the change I prefer it... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Fixes #53.
AdlerData.populate_phase_parameters()
, which should allow for easy population.Fixes #68.
sys.exit()
toraise Exception()
instead.Fixes #67:
Fixes #63.
Fixes #64.
.to_table()
call.Review Checklist for Source Code Changes