Refactor and adding filters.

[astronomerritt]

Code refactor:

• This should be the final big rearrangement, at least for a long while. This is about as neat and maintainable as I can get with my current skillset.
• The DataSchema parent class has been eliminated. Always best to avoid inheritance where you can.
• There are now custom constructor classmethods on all classes. See adler.py for how AdlerPlanetoid should now be called.
• The dataclasses now each have their own file. Because I was very tired of scrolling.
• There's an additional module for utility functions for the dataclasses.

Fixes #37.

• The user can now supply a comma-separated list of filters to the command line. By default, all filters are used.
• The Observations object on AdlerPlanetoid is now observations_by_filter, a list of Observations objects in the order of the list of filters.
• SSObject has many filter-dependent fields. These are now correctly pulled down from the RSP and organised into arrays, once again in the order specified by the list of filters.

Fixes #66.

• Incidentally, the refactor now ensures the TAPService object is only created once.

Review Checklist for Source Code Changes

• Does pip install still work?
• Have you written a unit test for any new functions?
• Do all the units tests run successfully?
• Does adler run successfully on a test set of input files/databases?
• Have you used black on the files you have updated to confirm python programming style guide enforcement?

[astronomerritt]

Fixed a typo on AdlerPlanetoid.populate_observations() that was causing observations_by_filter[0].filter_name to show up as "filter" rather than the actual filter name string.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 69.84%. Comparing base (610d429) to head (6ae74ca).

Files	Patch %	Lines
src/adler/adler.py	0.00%	3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   72.13%   69.84%   -2.29%     
==========================================
  Files           3        3              
  Lines          61       63       +2     
==========================================
  Hits           44       44              
- Misses         17       19       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jrob93]

Following from me playing around with the new AdlerPlanetoid and our quick chat, it would be useful to be able to retrieve a given filter from a planetoid object containing many filters. Something like:

obs_r = planetoid.observations_in_filter("r")
obs_r.mag

This would address the issue of having the user look up which index to use for a given filter_list (noting that the index would change if filter_list ever changes)

[astronomerritt]

Following from me playing around with the new AdlerPlanetoid and our quick chat, it would be useful to be able to retrieve a given filter from a planetoid object containing many filters. Something like:

obs_r = planetoid.observations_in_filter("r")
obs_r.mag

This would address the issue of having the user look up which index to use for a given filter_list (noting that the index would change if filter_list ever changes)

Done.

As we discussed earlier, it's probably also a good idea to have something like this for the AdlerData class to retrieve parameters by model/filter. Made an issue for that: #74.

[jrob93]

Awesome, that's exactly what I wanted!

[astronomerritt]

@mschwamb would you like to look at this or shall I go ahead and merge?

[mschwamb]

If Jamie is happy, I am happy