Phasecurve

[jrob93]

Create the initial PhaseCurve class, contains the modules required to initialise an sbpy phase curve model, get the model reduced mag from phase angle and do some a simple model fit to observations. Unit tests to follow.

Closes #44

Review Checklist for Source Code Changes

• Does pip install still work?
• Have you written a unit test for any new functions?
• Do all the units tests run successfully?
• Have you used black on the files you have updated to confirm python programming style guide enforcement?

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 53.84615% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 62.60%. Comparing base (b080dda) to head (fb90a0b).

Files	Patch %	Lines
src/adler/science/PhaseCurve.py	57.14%	21 Missing ⚠️
src/adler/adler.py	0.00%	3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   69.84%   62.60%   -7.24%     
==========================================
  Files           3        4       +1     
  Lines          63      115      +52     
==========================================
+ Hits           44       72      +28     
- Misses         19       43      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jrob93]

Added some basic unit tests

[astronomerritt]

I think you need to re-pull and merge main here - this isn't compatible with the latest changes to the dataclasses (sorry!). When I run:

>> adler -s 8268570668335894776

I'm getting:

Traceback (most recent call last):
  File "/home/smerritt/.local/bin/adler", line 8, in <module>
    sys.exit(main())
  File "/home/smerritt/adler/src/adler/adler.py", line 31, in main
    runAdler(args)
  File "/home/smerritt/adler/src/adler/adler.py", line 13, in runAdler
    pc = PhaseCurve(abs_mag=planetoid.SSObject.r_H, phase_param=0.2, model_name="HG")
AttributeError: 'SSObject' object has no attribute 'r_H'

This should be SSObject.H[2], I believe. SSObject's filter-dependent class attributes are now lists in the order of the requested filters.

[jrob93]

Cool, I forgot about the command line stuff. I'll just change that bit to what you suggested. This will probably be changed later when issue #77 is dealt with

[astronomerritt]

Yep, just fix for now so everything runs - once I've gotten around to #77 I'll change the call in adler.py as well!