-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helper function for SSObject, test improvements #94
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
==========================================
+ Coverage 84.71% 93.29% +8.57%
==========================================
Files 14 12 -2
Lines 373 343 -30
==========================================
+ Hits 316 320 +4
+ Misses 57 23 -34 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this and it looks great. I appreciate you getting it working very similar to the other functions! My commit has updated the example notebook to use this (and also to roll loading data from local file/RSP into one nb)
Awesome, thanks! |
Fixes #77.
The filter-dependent values on SSObject can now be very easily retrieved in exactly the same manner as filter-specific observations:
test_planetoid.SSObject_in_filter("r").H
You may note I have done this in a rather involved way: I have created a new dataclass just to store these values (
FilterDependentSSO
) and nowSSObject
stores a list of these, one per filter. This was to maintain consistency on the user end:observations_in_filter()
andSSObject_in_filter()
both return objects, which thus have their values accessed in exactly the same way. It's also consistent with how AdlerPlanetoid stores the Observations objects.Also:
SSObject_in_filter()
observations_in_filter()
andAdlerPlanetoid.construct_from_SQL()
Review Checklist for Source Code Changes