DM-49695: Allow hasattr to work for table for dunder properties if non-contiguous #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other property requests will fail.
timj
commented
Mar 25, 2025
| attr = getattr(self.columns, name) | ||
| except Exception as e: | ||
| e.add_note(f"Error retrieving column attribute '{name}' from {type(self)}") | ||
| raise |
There was a problem hiding this comment.
I assume reraising this as an AttributeError would break things?
There was a problem hiding this comment.
Correct. The non-contiguous case in particular should be its original exception type.
TallJimbo
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other property requests will fail.