-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-48582: factor out configs that are repeated for each kind of visit/source analysis #347
Open
TallJimbo
wants to merge
10
commits into
main
Choose a base branch
from
tickets/DM-48582
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8cc1f77
Don't run flake8 on (to-be-added) config directory.
TallJimbo 3b4af3b
Factor matched-visit configuration into config files.
TallJimbo cbd817e
Factor visit analysis configuration into config files.
TallJimbo d1e2973
Default to tract dimensions in MakeMetricTableTask.
TallJimbo 1421b8d
Factor matched-visit whole sky plot into config file.
TallJimbo 5193dfa
Run standard matchedVisit suite in default matchedPreVisit.
TallJimbo e3f0edf
Add analyzePreSourceTableCore to visitQualityCore.
TallJimbo f41293d
Add catalogMatchPreVisit to visitQualityCore.
TallJimbo f6c6b37
Ensure arrays passed to plotProjectionWithBinning have same shape.
TallJimbo 9f28494
Don't drop full visits for bad detectors.
TallJimbo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
# Configuration for extended instances of | ||
# lsst.analysis.tools.tasks.AssociatedSourcesTractAnalysisTask | ||
# | ||
# This does not include standard configuration, as it may be used by instances | ||
# that are configured to optionally run alongside instances with that | ||
# configurations. | ||
|
||
from lsst.analysis.tools.atools import * | ||
from lsst.analysis.tools.interfaces import * | ||
|
||
config.atools.modelPhotRepStarSn5to10 = StellarPhotometricRepeatability | ||
config.atools.modelPhotRepStarSn5to10.fluxType = "gaussianFlux" | ||
config.atools.modelPhotRepStarSn5to10.process.filterActions.perGroupStdevFiltered.selectors.sn.minimum = 5 | ||
config.atools.modelPhotRepStarSn5to10.process.filterActions.perGroupStdevFiltered.selectors.sn.maximum = 10 | ||
config.atools.modelPhotRepStarSn5to10.produce.plot = NoPlot | ||
|
||
config.atools.modelPhotRepStarSn10to20 = StellarPhotometricRepeatability | ||
config.atools.modelPhotRepStarSn10to20.fluxType = "gaussianFlux" | ||
config.atools.modelPhotRepStarSn10to20.process.filterActions.perGroupStdevFiltered.selectors.sn.minimum = 10 | ||
config.atools.modelPhotRepStarSn10to20.process.filterActions.perGroupStdevFiltered.selectors.sn.maximum = 20 | ||
config.atools.modelPhotRepStarSn10to20.produce.plot = NoPlot | ||
|
||
config.atools.modelPhotRepStarSn20to40 = StellarPhotometricRepeatability | ||
config.atools.modelPhotRepStarSn20to40.fluxType = "gaussianFlux" | ||
config.atools.modelPhotRepStarSn20to40.process.filterActions.perGroupStdevFiltered.selectors.sn.minimum = 20 | ||
config.atools.modelPhotRepStarSn20to40.process.filterActions.perGroupStdevFiltered.selectors.sn.maximum = 40 | ||
config.atools.modelPhotRepStarSn20to40.produce.plot = NoPlot | ||
|
||
config.atools.modelPhotRepStarSn40to80 = StellarPhotometricRepeatability | ||
config.atools.modelPhotRepStarSn40to80.fluxType = "gaussianFlux" | ||
config.atools.modelPhotRepStarSn40to80.process.filterActions.perGroupStdevFiltered.selectors.sn.minimum = 40 | ||
config.atools.modelPhotRepStarSn40to80.process.filterActions.perGroupStdevFiltered.selectors.sn.maximum = 80 | ||
config.atools.modelPhotRepStarSn40to80.produce.plot = NoPlot | ||
|
||
config.atools.psfPhotRepStarSn5to10 = StellarPhotometricRepeatability | ||
config.atools.psfPhotRepStarSn5to10.process.filterActions.perGroupStdevFiltered.selectors.sn.minimum = 5 | ||
config.atools.psfPhotRepStarSn5to10.process.filterActions.perGroupStdevFiltered.selectors.sn.maximum = 10 | ||
config.atools.psfPhotRepStarSn5to10.produce.plot = NoPlot | ||
|
||
config.atools.psfPhotRepStarSn10to20 = StellarPhotometricRepeatability | ||
config.atools.psfPhotRepStarSn10to20.process.filterActions.perGroupStdevFiltered.selectors.sn.minimum = 10 | ||
config.atools.psfPhotRepStarSn10to20.process.filterActions.perGroupStdevFiltered.selectors.sn.maximum = 20 | ||
config.atools.psfPhotRepStarSn10to20.produce.plot = NoPlot | ||
|
||
config.atools.psfPhotRepStarSn20to40 = StellarPhotometricRepeatability | ||
config.atools.psfPhotRepStarSn20to40.process.filterActions.perGroupStdevFiltered.selectors.sn.minimum = 20 | ||
config.atools.psfPhotRepStarSn20to40.process.filterActions.perGroupStdevFiltered.selectors.sn.maximum = 40 | ||
config.atools.psfPhotRepStarSn20to40.produce.plot = NoPlot | ||
|
||
config.atools.psfPhotRepStarSn40to80 = StellarPhotometricRepeatability | ||
config.atools.psfPhotRepStarSn40to80.process.filterActions.perGroupStdevFiltered.selectors.sn.minimum = 40 | ||
config.atools.psfPhotRepStarSn40to80.process.filterActions.perGroupStdevFiltered.selectors.sn.maximum = 80 | ||
config.atools.psfPhotRepStarSn40to80.produce.plot = NoPlot |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
# Configuration for standard instances of | ||
# lsst.analysis.tools.tasks.AssociatedSourcesTractAnalysisTask | ||
|
||
from lsst.analysis.tools.atools import * | ||
|
||
config.atools.stellarAstrometricSelfRepeatabilityRA = AstrometricRepeatability | ||
config.atools.stellarAstrometricSelfRepeatabilityRA.coordinate = "RA" | ||
config.atools.stellarAstrometricSelfRepeatabilityRA.level = 2 | ||
config.atools.stellarAstrometricSelfRepeatabilityDec = AstrometricRepeatability | ||
config.atools.stellarAstrometricSelfRepeatabilityDec.coordinate = "Dec" | ||
config.atools.stellarAstrometricSelfRepeatabilityDec.level = 2 | ||
config.atools.stellarPhotometricRepeatability = StellarPhotometricRepeatability | ||
config.atools.stellarPhotometricResiduals = StellarPhotometricResidualsFocalPlane | ||
config.atools.stellarPhotometricRepeatabilityCalib = StellarPhotometricRepeatability | ||
config.atools.stellarPhotometricRepeatabilityCalib.fluxType = "calibFlux" | ||
config.atools.stellarPhotometricResidualsCalib = StellarPhotometricResidualsFocalPlane | ||
config.atools.stellarPhotometricResidualsCalib.fluxType = "calibFlux" | ||
config.atools.stellarAstrometricResidualsRA = StellarAstrometricResidualsRAFocalPlanePlot | ||
config.atools.stellarAstrometricResidualsDec = StellarAstrometricResidualsDecFocalPlanePlot | ||
config.atools.stellarAstrometricResidualStdDevRA = StellarAstrometricResidualStdDevRAFocalPlanePlot | ||
config.atools.stellarAstrometricResidualStdDevDec = StellarAstrometricResidualStdDevDecFocalPlanePlot | ||
config.atools.stellarAstrometricRepeatability1 = AstrometricRelativeRepeatability | ||
config.atools.stellarAstrometricRepeatability1.xValue = 1 | ||
config.atools.stellarAstrometricRepeatability1.process.calculateActions.rms.annulus = 5 | ||
config.atools.stellarAstrometricRepeatability2 = AstrometricRelativeRepeatability | ||
config.atools.stellarAstrometricRepeatability2.xValue = 2 | ||
config.atools.stellarAstrometricRepeatability2.process.calculateActions.rms.annulus = 20 | ||
config.atools.stellarAstrometricRepeatability3 = AstrometricRelativeRepeatability | ||
config.atools.stellarAstrometricRepeatability3.xValue = 3 | ||
config.atools.stellarAstrometricRepeatability3.process.calculateActions.rms.annulus = 200 | ||
config.atools.stellarAstrometricRepeatability3.process.calculateActions.rms.threshAD = 30 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
# Configuration for instances of lsst.analysis.tools.tasks.WholeSkyAnalysisTask | ||
# that aggregate metrics from the standard configuration of | ||
# lsst.analysis.tools.tasks.AssociatedSourcesTractAnalysisTask. | ||
|
||
from lsst.analysis.tools.atools import * | ||
|
||
config.atools.wholeSkyMetric = WholeSkyPlotTool | ||
config.atools.wholeSkyMetric.plotKeys = [] | ||
config.atools.wholeSkyMetric.keysWithBand = [ | ||
"stellarAstrometricRepeatability1_{band}_AM1", | ||
"stellarAstrometricRepeatability1_{band}_AF1", | ||
"stellarAstrometricRepeatability1_{band}_AD1", | ||
"stellarAstrometricRepeatability2_{band}_AM2", | ||
"stellarAstrometricRepeatability2_{band}_AF2", | ||
"stellarAstrometricRepeatability2_{band}_AD2", | ||
"stellarAstrometricRepeatability3_{band}_AM3", | ||
"stellarAstrometricRepeatability3_{band}_AF3", | ||
"stellarAstrometricRepeatability3_{band}_AD3", | ||
"stellarAstrometricSelfRepeatabilityDec_{band}_dmL2AstroErr_Dec", | ||
"stellarAstrometricSelfRepeatabilityRA_{band}_dmL2AstroErr_RA", | ||
"stellarPhotometricRepeatability_{band}_stellarPhotRepeatStdev", | ||
"stellarPhotometricRepeatability_{band}_stellarPhotRepeatOutlierFraction", | ||
"stellarPhotometricResiduals_{band}_photResidTractSigmaMad", | ||
"stellarPhotometricResiduals_{band}_photResidTractStdev", | ||
"stellarPhotometricResiduals_{band}_photResidTractMedian", | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# Configuration for standard instances of | ||
# sst.analysis.tools.tasks.refCatSourceAnalysis.RefCatSourceAnalysisTask | ||
# | ||
# These configurations are not in the class default configs because there may | ||
# be instances of the class that are intended to optionally run alongside one | ||
# that includes this standard set. | ||
|
||
from lsst.analysis.tools.atools import * | ||
from lsst.analysis.tools.contexts import VisitContext | ||
|
||
config.atools.astromDiffRASkyVisitPlot = TargetRefCatDeltaRASkyVisitPlot | ||
config.atools.astromDiffDecSkyVisitPlot = TargetRefCatDeltaDecSkyVisitPlot | ||
config.atools.astromDiffRAScatterVisitPlot = TargetRefCatDeltaRAScatterVisitPlot | ||
config.atools.astromDiffDecScatterVisitPlot = TargetRefCatDeltaDecScatterVisitPlot | ||
config.atools.astromDiffMetrics = TargetRefCatDeltaMetrics | ||
config.atools.astromDiffMetrics.applyContext = VisitContext |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
# Configuration for standard instances of | ||
# sst.analysis.tools.tasks.refCatSourceAnalysis.RefCatSourceAnalysisTask | ||
# | ||
# These configurations are not in the class default configs because there may | ||
# be instances of the class that are intended to optionally run alongside one | ||
# that includes this standard set. | ||
|
||
from lsst.analysis.tools.atools import * | ||
|
||
config.atools.photomDiffPsfSkyVisitPlot = TargetRefCatDeltaPsfSkyVisitPlot | ||
config.atools.photomDiffAp09SkyVisitPlot = TargetRefCatDeltaAp09SkyVisitPlot | ||
config.atools.photoDiffPsfScatterVisitPlot = TargetRefCatDeltaPsfScatterVisitPlot | ||
config.atools.photoDiffCModelScatterVisitPlot = TargetRefCatDeltaAp09ScatterVisitPlot | ||
|
||
# TODO: should there be a VisitContext set here, too? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The contexts are applied in each atool so probably not. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
# Configuration for standard instances of | ||
# lsst.analysis.tools.tasks.SourceTableVisitAnalysisTask | ||
# | ||
# These configurations are not in the class default configs because there may | ||
# be instances of the class that are intended to optionally run alongside one | ||
# that includes this standard set. | ||
|
||
from lsst.analysis.tools.atools import * | ||
from lsst.analysis.tools.contexts import VisitContext | ||
|
||
config.atools.skyFluxVisitStatisticMetric = SkyFluxStatisticMetric | ||
config.atools.skyFluxVisitStatisticMetric.applyContext = VisitContext | ||
config.atools.skySourceSky = SkySourceSkyPlot | ||
config.atools.skySourceFlux = SkySourceHistPlot | ||
config.atools.relativeSizeResidualPlot = RelativeSizeResidualPlot |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing l