DM-45896: adapt to change in QG builder #348
Open
+18
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-slac
approved these changes
Feb 4, 2025
| @@ -649,7 +651,7 @@ def __init__( | |||
| @classmethod | |||
| def _add_gather_task( | |||
| cls, pipeline_graph: PipelineGraph, input_metadata_dataset_type: DatasetType | |||
| ) -> tuple[str, str]: | |||
| ) -> tuple[str | None, str | None]: | |||
There was a problem hiding this comment.
Should it be
tuple[str , str] | tuple[None, None]
instead?
| Label of the new task in the pipeline, or `None` if the given | ||
| dataset type is not a metadata dataset type or is itself a | ||
| gatherResourceUsage metadata dataset type. | ||
| gather_dataset_type_name : `str or `None` |
There was a problem hiding this comment.
Suggested change
| gather_dataset_type_name : `str or `None` | |
| gather_dataset_type_name : `str` or `None` |
This is another reminder that MyPy isn't actually being run in this package despite all of the type annotations (DM-40716), and I suspect it was never seen at runtime because the CLI automatically avoids these cases. But that's no reason to leave it broken at a lower level.
TallJimbo
force-pushed
the
tickets/DM-45896
branch
from
71a6f3d to
a41db74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.