DM-39938: Allow schema file to be a general URI #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebellm
reviewed
Aug 29, 2023
| self.alertSchema = alertPack.Schema.from_file(self.config.schemaFile) | ||
| uri = ResourcePath(self.config.schemaFile) | ||
| with uri.as_local() as schemaFile: | ||
| self.alertSchema = alertPack.Schema.from_file(schemaFile.ospath) |
There was a problem hiding this comment.
Would it make more sense to add a from_uri method to alert_packet.Schema? That would require making alert_packet dependent on lsst.resources but would hide some of this from users.
There was a problem hiding this comment.
Yes, if I did that then the lsst.alert.packet.schema could make use of ResourcePath directly and would be a bit simpler internally. I'm happy to switch over to that since it was the more natural thing for me to do, but I was worried you wouldn't like the new dependency (although it is on PyPI so shouldn't be a problem).
I will redo the PRs using ResourcePath to see what you think.
This allows it to be read from anywhere supported by ResourcePath.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows it to be read from anywhere supported by ResourcePath.
Requires lsst/alert_packet#35