DM-41063: Add nPixel filter for edge trailed sources and ignore filtering nans #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsmartradio
force-pushed
the
tickets/DM-41063
branch
3 times, most recently
from
bac7a14
to
c6483c4
Compare
mrawls
reviewed
Mar 19, 2024
bsmartradio
force-pushed
the
tickets/DM-41063
branch
from
c6483c4
to
cb6b761
Compare
bsmartradio
force-pushed
the
tickets/DM-41063
branch
3 times, most recently
from
bbfd602
to
55bacc7
Compare
bsmartradio
force-pushed
the
tickets/DM-41063
branch
from
80db655
to
a272da6
Compare
mrawls
approved these changes
May 2, 2024
bsmartradio
force-pushed
the
tickets/DM-41063
branch
5 times, most recently
from
0a8cd20
to
c5926b6
Compare
Move the trailed source filtering into filterDiaSourceCatalog. Additionally, update filtering so only trails that extend of the edge or which have long trails and are near the edge are filtered out, along with the sources which exceed the max trail length.
bsmartradio
force-pushed
the
tickets/DM-41063
branch
from
c5926b6
to
19cb1d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the new nan, off_image, and suspect_long_trail flags, update the edge filter to now only filter sources marked edge AND marked suspect_long_trail as well as sources flagged as off_image. Nan sources are now no longer automatically filtered, but do have an associated flag so that they can be looked at later.