DM-44996: Add error handling to PSF cutouts #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrawls
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Approving as a reasonable fix for error handling, but I have reservations about this possibly masking a more fundamental problem with getCutout and pixel vs sky coords. I hope I'm wrong, and either way, the logs this generates about DiaSources with centers in wonky locations will help trace the issue.
| cutoutPsf = None | ||
| except InvalidPsfError: | ||
| self.log.warning("Could not calculate PSF for DiaSource with " | ||
| "id=%i. InvalidPsfError encountered. Exiting." |
There was a problem hiding this comment.
Instead of "Exiting," prefer "Returning None for cutoutPsf" (as you noted above for when cutout is set to None)
isullivan
force-pushed
the
tickets/DM-44996
branch
from
cdcbf9c
to
22e17ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.