DM-45789: Optimize region for LoadDiaCatalogs #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kherner
approved these changes
Sep 6, 2024
A ConvexPolygon is now padded into a slightly larger ConvexPolygon, instead of a bounding circle. This should reduce the load size to ~64% of the previous solution.
kfindeisen
force-pushed
the
tickets/DM-45789
branch
from
c7f1442
to
82b0bd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a more precise implementation of
LoadDiaCatalogsConfig.angleMarginthat fits more closely to the detector footprint. The implementation is not guaranteed to move all sides of the footprint outward by exactlyangleMargin, but I assume such precision is not needed in a buffer.