DM-35504: Unify ap_pipe configs #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrawls
approved these changes
Nov 22, 2024
IsrTaskLSST has more inputs than IsrTask does.
These configs were originally a workaround for obs packages containing DRP-specific assumptions for CalibrateTask, CharacterizeImageTask, and the coadd tasks. We no longer use any of these tasks in AP pipeline, so the configs and the workarounds they enabled are unnecessary.
When we used a hack to reset certain task configs, the _ingredients configs needed to be re-applied after the reset. Now that the reset is gone, these configs can (and should) be inherited from _ingredients.
This task is deprecated, but its unit tests must continue using it despite the warnings. Since FutureWarning is correct behavior, test for it instead of suppressing it.
kfindeisen
force-pushed
the
tickets/DM-35504
branch
from
98b427b
to
b733ab0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the last traces of our
obs_*hacks and centralizes the remaining config (actually parameter) overrides in_ingredients. It also addresses a deprecation warning in the unit tests.