Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40562: Read pixel units from the FITS header #36

Merged
merged 7 commits into from
Sep 11, 2024

Conversation

arunkannawadi
Copy link
Member

@arunkannawadi arunkannawadi commented Sep 10, 2024

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • updated the FILE_FORMAT_VERSION number correctly (if python/lsst/cell_coadds/_fits.py was modified)

@arunkannawadi
Copy link
Member Author

Although _fits.py was modified, no bump is required since it doesn't affect how the file is persisted whatsoever. It affects only the reads.

python/lsst/cell_coadds/_fits.py Outdated Show resolved Hide resolved
@arunkannawadi arunkannawadi force-pushed the tickets/DM-40562 branch 2 times, most recently from 93a8319 to 5b770d2 Compare September 11, 2024 17:32
since the get method with a typed default guarantees that detector is
int. This change is in response to the commit
lsst/daf_butler@1c47f99
This consistency is needed to read and write units from/into FITS
format.
@arunkannawadi arunkannawadi merged commit 8b199b0 into main Sep 11, 2024
7 checks passed
@arunkannawadi arunkannawadi deleted the tickets/DM-40562 branch September 11, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants