DM-43077: Convert all tasks to use CalibrateImageTask outputs #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-43077
branch
from
e676d05 to
d6c5e7f
Compare
This is unnecessary, as there are many fewer detections.
parejkoj
force-pushed
the
tickets/DM-43077
branch
from
d6c5e7f to
058cd54
Compare
taranu
approved these changes
Oct 7, 2024
| @@ -91,7 +91,6 @@ def run(self, currentState: BuildState): | |||
| "-p", "$DRP_PIPE_DIR/pipelines/LSSTCam-imSim/DRP-ci_imsim.yaml", | |||
| "--skip-existing", | |||
| "--save-qgraph", os.path.join(self.runner.RunDir, QGRAPH_FILE), | |||
| "--config", f"calibrate:deblend.useCiLimits={not self.arguments.no_limit_deblend}", | |||
There was a problem hiding this comment.
Is this not implemented in the new task? I vaguely remember it didn't work right anyway and only the multiband one was really necessary (to limit Scarlet runtime, which might also be moot now).
|
|
||
| def testLocalPhotoCalibColumns(self): | ||
| """Check calexp's calibs are consistent with src's photocalib columns | ||
| """Check exposure's calibs are consistent with catalog's |
Previously, no_limit_deblend gave us the option to turn off useCiLimits for CalibrateTask. reprocessVisitImage is the new calibrate with useCiLimits=True in the ci_imsim pipeline by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.