-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-44545: Design initial calibration report format #58
Conversation
linearity: | ||
crosstalk: | ||
bfk: | ||
cti: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually we'll need to merge this and the version on DM-45843 if we want to move to one day using the same report template code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's my plan as well. I think this is compatible with the DM-45843 version, with this having only the minimum necessary fields (just the description).
fig.suptitle(title) | ||
fig.colorbar(im, cax=cax) | ||
fig.tight_layout() | ||
fig.savefig(target_uri.path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want a plt.close here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know. If I'm reading the changelog for make_figure
correctly (https://github.com/lsst/utils/blob/7d0def3d61c752f736c8d2cc33852495fcc90713/doc/changes/DM-44725.md?plain=1), then I think no, because this figure is independent of pyplot
in some fashion. I've not added one, and hope that when the method ends, the fig
drops out of scope and is cleared.
acd3aa4
to
26344b1
Compare
This adds a command line
cpv_report.py
that generates a web accessible calibration report from a butler repo and list of collections into an output directory.