Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40002: Support pydantic v1 and v2 #253

Closed
wants to merge 3 commits into from
Closed

DM-40002: Support pydantic v1 and v2 #253

wants to merge 3 commits into from

Conversation

timj
Copy link
Member

@timj timj commented Jul 18, 2023

Requires lsst/daf_butler#866

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (1408350) 85.51% compared to head (9517a62) 85.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
+ Coverage   85.51%   85.55%   +0.03%     
==========================================
  Files          47       47              
  Lines        4247     4244       -3     
  Branches      732      732              
==========================================
- Hits         3632     3631       -1     
+ Misses        461      459       -2     
  Partials      154      154              
Impacted Files Coverage Δ
python/lsst/ctrl/mpexec/reports.py 100.00% <100.00%> (+3.12%) ⬆️
tests/test_reports.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

timj added 2 commits July 19, 2023 16:33
pydantic v2 no longer accepts an indent value.
@timj
Copy link
Member Author

timj commented Sep 21, 2023

I can't really remember why this was never merged, but it was superseded by #255.

@timj timj closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants