DM-40332: improve logging and simplify existence checks in SingleQuantumExecutor #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
==========================================
+ Coverage 85.36% 85.50% +0.13%
==========================================
Files 47 47
Lines 4271 4269 -2
Branches 745 742 -3
==========================================
+ Hits 3646 3650 +4
+ Misses 467 462 -5
+ Partials 158 157 -1
☔ View full report in Codecov by Sentry. |
timj
approved these changes
Aug 7, 2023
Logic branches for unresolved dataset refs in quanta and the old version of pipeline mocking are no longer relevant.
TallJimbo
force-pushed
the
tickets/DM-40332
branch
from
fd38f97
to
a9f47df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes