DM-40390: Remove TYPE_CHECKING block to fix DatastoreRecordData import #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a code path that was using the class but which failed because it was only imported during type checking.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
==========================================
+ Coverage 85.50% 87.00% +1.50%
==========================================
Files 47 47
Lines 4269 4301 +32
Branches 601 745 +144
==========================================
+ Hits 3650 3742 +92
+ Misses 462 404 -58
+ Partials 157 155 -2
☔ View full report in Codecov by Sentry. |
The test has an intentional failure caused by updateRun being broken. The test should be fixed on DM-40392.
TallJimbo
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a code path that was using the class but which failed because it was only imported during type checking.
Checklist
doc/changes