-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-41542: Add --summary option to pipetask qgraph. #288
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #288 +/- ##
==========================================
+ Coverage 86.83% 87.35% +0.52%
==========================================
Files 49 50 +1
Lines 4542 4588 +46
Branches 780 786 +6
==========================================
+ Hits 3944 4008 +64
+ Misses 441 420 -21
- Partials 157 160 +3 ☔ View full report in Codecov by Sentry. |
ea4b82b
to
24cd187
Compare
tests/test_cliCmdQgraph.py
Outdated
qgraph.saveUri(graph_uri) | ||
|
||
# test_filename = os.path.join(self.root, "summary.json") | ||
test_filename = "/tmp/summary.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should one of these go away, and is the right one commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that. I was getting vague pydantic validation error messages and needed to see the json to figure it out. I forgot to get rid of the tmp line.
24cd187
to
7673ee8
Compare
7673ee8
to
c9c5ed8
Compare
Checklist
doc/changes