Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-41542: Add --summary option to pipetask qgraph. #288

Merged
merged 4 commits into from
Apr 17, 2024

Conversation

MichelleGower
Copy link
Contributor

@MichelleGower MichelleGower commented Apr 11, 2024

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 95.08197% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 87.35%. Comparing base (f5ec60c) to head (24cd187).
Report is 12 commits behind head on main.

❗ Current head 24cd187 differs from pull request most recent head c9c5ed8. Consider uploading reports for the commit c9c5ed8 to get more accurate results

Files Patch % Lines
python/lsst/ctrl/mpexec/cli/cmd/commands.py 71.42% 0 Missing and 2 partials ⚠️
python/lsst/ctrl/mpexec/cmdLineFwk.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
+ Coverage   86.83%   87.35%   +0.52%     
==========================================
  Files          49       50       +1     
  Lines        4542     4588      +46     
  Branches      780      786       +6     
==========================================
+ Hits         3944     4008      +64     
+ Misses        441      420      -21     
- Partials      157      160       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichelleGower MichelleGower force-pushed the tickets/DM-41542 branch 3 times, most recently from ea4b82b to 24cd187 Compare April 15, 2024 16:55
qgraph.saveUri(graph_uri)

# test_filename = os.path.join(self.root, "summary.json")
test_filename = "/tmp/summary.json"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should one of these go away, and is the right one commented out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that. I was getting vague pydantic validation error messages and needed to see the json to figure it out. I forgot to get rid of the tmp line.

@MichelleGower MichelleGower merged commit 9f21ca1 into main Apr 17, 2024
13 checks passed
@MichelleGower MichelleGower deleted the tickets/DM-41542 branch April 17, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants